Skip to content

[18.0][MIG] base_external_system: Migration to 18.0#447

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
Therp:18.0-mig-base_external_system
Jun 3, 2026
Merged

[18.0][MIG] base_external_system: Migration to 18.0#447
OCA-git-bot merged 1 commit into
OCA:18.0from
Therp:18.0-mig-base_external_system

Conversation

@NL66278

@NL66278 NL66278 commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

The module base_external_system will be the base for other modules to be migrated:

  • base_external_system_http
  • base_external_system_ms_client_assertion
  • base_external_system_oauth
  • base_external_system_odoorpc

@tendil

tendil commented Apr 21, 2026

Copy link
Copy Markdown

@NL66278 could you please do a rebase? Thank you!

@NL66278 NL66278 force-pushed the 18.0-mig-base_external_system branch from 595a083 to 7abd05e Compare April 21, 2026 10:02
@OCA-git-bot OCA-git-bot added series:18.0 mod:base_external_system Module base_external_system labels Apr 21, 2026
@NL66278

NL66278 commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

The original contents of the PR where a full migration of the improved 16.0 version, that unfortunately was never merged. Now that the unimproved 16.0 version has been merged into 18.0, I freshly reïmplemented the 16.0 improvements.

@Kiplangatdan Kiplangatdan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NL66278 There are some obsolete files no longer used, otherwise this looks good:
../models/external_system_os.py
../tests/test_external_system_os.py

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@NL66278

NL66278 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

@NL66278 There are some obsolete files no longer used, otherwise this looks good: ../models/external_system_os.py ../tests/test_external_system_os.py

@Kiplangatdan Those files are really not there. Maybe in your working directory, but not in the PR. Please have another look.

@Kiplangatdan

Copy link
Copy Markdown
Member

@NL66278 There are some obsolete files no longer used, otherwise this looks good: ../models/external_system_os.py ../tests/test_external_system_os.py

@Kiplangatdan Those files are really not there. Maybe in your working directory, but not in the PR. Please have another look.

@NL66278 It doesn't show in the PR because they were never touched:

https://github.com/Therp/server-backend/blob/18.0-mig-base_external_system/base_external_system/models/external_system_os.py

https://github.com/Therp/server-backend/blob/18.0-mig-base_external_system/base_external_system/tests/test_external_system_os.py

@NL66278 NL66278 force-pushed the 18.0-mig-base_external_system branch from 7abd05e to 42eaa6d Compare June 3, 2026 08:58
@NL66278

NL66278 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

@Kiplangatdan Ah, I got confused because this was originally part of a migration branch. Files have now been removed.

@thomaspaulb

Copy link
Copy Markdown

/ocabot migration base_external_system

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jun 3, 2026
@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-447-by-thomaspaulb-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 3, 2026
14 tasks
@OCA-git-bot OCA-git-bot merged commit ba19fb7 into OCA:18.0 Jun 3, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 06081b2. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants